Xikui Wang has posted comments on this change. Change subject: Add user-stream for Twitter Adaptor ......................................................................
Patch Set 2: (1 comment) The user whose access token is used in the feed creation, is the one that we are monitoring. https://asterix-gerrit.ics.uci.edu/#/c/1272/2/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java: Line 68: } > Can we extract the common code from these three constructors and move it to Yeah. Basically the only part that could be shrunk is the tweetListener.setInputQ(inputQ). But the tweetListener(s) are not the same in them, should I cast all to be tweetListener? -- To view, visit https://asterix-gerrit.ics.uci.edu/1272 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99cdd4cb667306d378317616f9811dfce3e6d838 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes