abdullah alamoudi has posted comments on this change. Change subject: Fix Upsert Pipeline ......................................................................
Patch Set 3: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/1308/3/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/AsterixLSMPrimaryUpsertOperatorNodePushable.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/AsterixLSMPrimaryUpsertOperatorNodePushable.java: Line 97: || (filterFieldIndex >= 0 && (fieldPermutation.length > numOfPrimaryKeys + 2))); > Why is meta always before filter? Shouldn't meta be set to something like - because if hasMeta is false, then this field will not be used at all. Line 202: } > What was happening previously with meta/filter? we used to write those to the output frame after we do the insert, by that time, it is too late because their values have changed Line 218: } > Is the crux of the fix here that the modCallBack.setOp(Operation.DELETE) go not that the modCallback was moved here but that the delete (219-224) was postponed after we have written the value to the output frame https://asterix-gerrit.ics.uci.edu/#/c/1308/3/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/InsertDeleteUpsertOperator.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/InsertDeleteUpsertOperator.java: Line 96: } > Why does the order matter here? Is it determining the order of the fields t it determines the order of fields that will come out of the insert-delete-upsert pipeline. Upsert is the only operation which produces new variables and I switched the order to avoid copying of the delete tuple to a temporary memory perform the delete/upsert, write the new record value and then write the deleted value. -- To view, visit https://asterix-gerrit.ics.uci.edu/1308 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c19d448f9664ecaeac600668a6dbdcf40673c56 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Murtadha Hubail <hubail...@gmail.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
