Michael Blow has posted comments on this change. Change subject: [NO ISSUE][STO] Notify completiong of IO request in finally ......................................................................
Patch Set 3: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/2839/3//COMMIT_MSG Commit Message: PS3, Line 7: completiong completion* https://asterix-gerrit.ics.uci.edu/#/c/2839/3/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IoRequest.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IoRequest.java: PS3, Line 146: Offer failing means we're over capacity and this should be garbage collected how can we ever be over capacity? https://asterix-gerrit.ics.uci.edu/#/c/2839/3/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java: PS3, Line 145: if (LOGGER.isWarnEnabled()) { remove PS3, Line 204: if (LOGGER.isWarnEnabled()) { remove PS3, Line 205: e.getMessage() this is terrible, and will often be "null"- the message will already be logged as part of including the exception to the log- if we really need this log at all, please change this to be some string describing what we're doing in the try block PS3, Line 713: if (LOGGER.isWarnEnabled()) { remove -- To view, visit https://asterix-gerrit.ics.uci.edu/2839 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b3003b47b6b181856faf82aca6e828ee014527c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-HasComments: Yes
