Taewoo Kim has posted comments on this change. Change subject: ASTERIXDB-1736: Remove Grace Hash Join and Hybrid Hash Join (not being used) ......................................................................
Patch Set 2: Thanks for the comment. If we have a correctness issue in the optimized hybrid hash join, then we we can put a designed data set and check the correctness of the result after fixing the bug. Also, for the code-wise, since HashTable now uses the bufferManager interface to get/release frames, that structure needs to be reflected in the hybrid hash join, too. -- To view, visit https://asterix-gerrit.ics.uci.edu/1353 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16e9e4c73d7851f18a48c2715a6bc5c903b74eba Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <wangs...@yahoo.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Taewoo Kim <wangs...@yahoo.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-HasComments: No
