Michael Blow has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes ......................................................................
Patch Set 1: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2865/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatTask.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatTask.java: PS1, Line 72: trace i mean sure, but it's only once every 10 (30 in some extensions) seconds by default... https://asterix-gerrit.ics.uci.edu/#/c/2865/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java: PS1, Line 190: LOGGER.trace("Reclaimed pages = {}", reclaimedPages perhaps we'd be saved at runtime w/ inlining, but otherwise we will have a boxing of reclaimedPages here- should we surround with an is enabled check and restore the concatenation? -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
