Murtadha Hubail has submitted this change and it was merged. Change subject: [NO ISSUE][OTH] Log Level Fixes ......................................................................
[NO ISSUE][OTH] Log Level Fixes - user model changes: no - storage format changes: no - interface changes: no Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Reviewed-on: https://asterix-gerrit.ics.uci.edu/2865 Sonar-Qube: Jenkins <[email protected]> Reviewed-by: Michael Blow <[email protected]> Tested-by: Michael Blow <[email protected]> --- M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatComputeTask.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatTask.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractFrameSorter.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java 4 files changed, 8 insertions(+), 9 deletions(-) Approvals: Jenkins: No violations found Michael Blow: Looks good to me, approved; Verified diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatComputeTask.java b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatComputeTask.java index 9bfd061..81ceea5 100644 --- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatComputeTask.java +++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatComputeTask.java @@ -103,6 +103,6 @@ ncs.getNodeControllerData().notifyHeartbeat(hbData); } - LOGGER.log(Level.DEBUG, "Successfully refreshed heartbeat data"); + LOGGER.trace("Successfully refreshed heartbeat data"); } } diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatTask.java b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatTask.java index 9160e46..6d08fb1 100644 --- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatTask.java +++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatTask.java @@ -69,7 +69,7 @@ synchronized (hbData) { cc.nodeHeartbeat(ncId, hbData); } - LOGGER.log(Level.DEBUG, "Successfully sent heartbeat"); + LOGGER.trace("Successfully sent heartbeat"); return true; } catch (InterruptedException e) { throw e; diff --git a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractFrameSorter.java b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractFrameSorter.java index f51271e..980ad9b 100644 --- a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractFrameSorter.java +++ b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractFrameSorter.java @@ -235,8 +235,8 @@ } maxFrameSize = Math.max(maxFrameSize, outputFrame.getFrameSize()); outputAppender.write(writer, true); - if (LOGGER.isDebugEnabled()) { - LOGGER.debug( + if (LOGGER.isTraceEnabled()) { + LOGGER.trace( "Flushed records:" + limit + " out of " + tupleCount + "; Flushed through " + (io + 1) + " frames"); } return maxFrameSize; diff --git a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java index e63a5b8..0a7c842 100644 --- a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java +++ b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java @@ -40,7 +40,6 @@ import org.apache.hyracks.storage.common.file.FileMapManager; import org.apache.hyracks.storage.common.file.IFileMapManager; import org.apache.hyracks.util.JSONUtil; -import org.apache.logging.log4j.Level; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; @@ -126,8 +125,8 @@ } private void logStats() { - if (LOGGER.isInfoEnabled()) { - LOGGER.log(Level.INFO, "Free (allocated) pages = " + freePages.size() + ". Budget = " + pageBudget + if (LOGGER.isTraceEnabled()) { + LOGGER.trace("Free (allocated) pages = " + freePages.size() + ". Budget = " + pageBudget + ". Large pages = " + largePages.get() + ". Overall usage = " + used.get()); } } @@ -188,8 +187,8 @@ bucket.bucketLock.unlock(); } } - if (LOGGER.isInfoEnabled()) { - LOGGER.log(Level.INFO, "Reclaimed pages = " + reclaimedPages); + if (LOGGER.isTraceEnabled()) { + LOGGER.trace("Reclaimed pages = " + reclaimedPages); } logStats(); } -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]>
