Till Westmann has posted comments on this change. Change subject: Cleanup FileSplit and FileReference ......................................................................
Patch Set 4: Code-Review+2 (7 comments) Need to fix more things in the next few days. https://asterix-gerrit.ics.uci.edu/#/c/1352/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java: Line 184: partition.put("relative", relative); Seems that we're changing an external interface here. Who is using this interface? Do we change the code as well? https://asterix-gerrit.ics.uci.edu/#/c/1352/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/AsterixNCAppRuntimeContext.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/AsterixNCAppRuntimeContext.java: Line 173: fileMapManager = new AsterixFileMapManager(ioManager); Why does the AsterixFileMapManager need the ioMananger? https://asterix-gerrit.ics.uci.edu/#/c/1352/4/asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java: Line 159: element1.put("relative", true); Ok, this modifies the test that is supposed to validate that the interface does not change ... https://asterix-gerrit.ics.uci.edu/#/c/1352/4/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/AsterixVirtualBufferCacheProvider.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/AsterixVirtualBufferCacheProvider.java: Line 55: if (next == device) { Use equals instead of == ? Seems more robust wrt change in the code base. If this is performance critical we might want to reconsider the linear search. https://asterix-gerrit.ics.uci.edu/#/c/1352/4/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java: Line 169: validateDatasetLifecycleManagerState(); Indentation seems wrong. https://asterix-gerrit.ics.uci.edu/#/c/1352/4/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/Resource.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/Resource.java: Line 33: public abstract class Resource implements Serializable { That's a very generic name. What is it really about? Can we add a descriptive comment? https://asterix-gerrit.ics.uci.edu/#/c/1352/4/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java: Line 40: import org.apache.hyracks.api.io.FileSplit; Why do we need to move this? -- To view, visit https://asterix-gerrit.ics.uci.edu/1352 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fac508bf9af5a3bed41a3cf4464d2cbfecf2f61 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <hubail...@gmail.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
