Michael Blow has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2891
Change subject: [NO ISSUE][OTH] Log level / SonarQube fixes
......................................................................
[NO ISSUE][OTH] Log level / SonarQube fixes
Change-Id: I8e9a31ebea1eac6bed26c57666db1fd4b1208295
---
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/CleanupJobletWork.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMMemoryComponent.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ComponentReplacementContext.java
3 files changed, 8 insertions(+), 11 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/91/2891/1
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/CleanupJobletWork.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/CleanupJobletWork.java
index d415da1..ae2cfa0 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/CleanupJobletWork.java
+++
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/CleanupJobletWork.java
@@ -45,9 +45,7 @@
@Override
public void run() {
- if (LOGGER.isInfoEnabled()) {
- LOGGER.info("Cleaning up after job: " + jobId);
- }
+ LOGGER.debug("cleaning up after job: {}", jobId);
ncs.removeJobParameterByteStore(jobId);
ncs.getPartitionManager().jobCompleted(jobId, status);
Map<JobId, Joblet> jobletMap = ncs.getJobletMap();
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMMemoryComponent.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMMemoryComponent.java
index 278098f..9440648 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMMemoryComponent.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMMemoryComponent.java
@@ -30,7 +30,6 @@
import org.apache.hyracks.storage.am.lsm.common.api.LSMOperationType;
import org.apache.hyracks.storage.am.lsm.common.util.LSMComponentIdUtils;
import org.apache.hyracks.storage.common.buffercache.IBufferCache;
-import org.apache.logging.log4j.Level;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
@@ -276,7 +275,7 @@
allocated = true;
} finally {
if (!allocated) {
- ((IVirtualBufferCache) getIndex().getBufferCache()).close();
+ getIndex().getBufferCache().close();
}
}
}
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ComponentReplacementContext.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ComponentReplacementContext.java
index dad3bdc..59d5fd0 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ComponentReplacementContext.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ComponentReplacementContext.java
@@ -156,12 +156,12 @@
replacedComponentIds.add(components.get(i).getId());
// ensure that disk component exists
boolean found = false;
- LOGGER.log(Level.INFO, "Looking for a component with the id: " +
replacedComponentIds.get(i));
- for (int j = 0; j < allDiskComponents.size(); j++) {
- ILSMDiskComponent dc = allDiskComponents.get(j);
+ final ILSMComponentId replacedComponentId =
replacedComponentIds.get(i);
+ LOGGER.debug("looking for a component with the id: {}",
replacedComponentId);
+ for (ILSMDiskComponent dc : allDiskComponents) {
ILSMComponentId diskComponentId = dc.getId();
- LOGGER.log(Level.INFO, "Next disk component id: " +
diskComponentId);
- if (diskComponentId.equals(replacedComponentIds.get(i))) {
+ LOGGER.info("next disk component id: {}", diskComponentId);
+ if (diskComponentId.equals(replacedComponentId)) {
found = true;
diskComponents.add(dc);
break;
@@ -169,7 +169,7 @@
}
if (!found) {
// component has been merged?
- LOGGER.log(Level.WARN, "Memory Component with id = " +
replacedComponentIds.get(i)
+ LOGGER.log(Level.WARN, "Memory Component with id = " +
replacedComponentId
+ " was flushed and merged before search cursor
replaces it");
return false;
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/2891
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e9a31ebea1eac6bed26c57666db1fd4b1208295
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <[email protected]>
