Michael Blow has posted comments on this change.

Change subject: [NO ISSUE] asterix-docker profilization
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2945/1/asterixdb/asterix-docker/pom.xml
File asterixdb/asterix-docker/pom.xml:

PS1, Line 42:   <profiles>
            :     <profile>
            :         <id>docker</id>
I guess this works too, but I was thinking to do the profile selection in the 
parent, and only include the module if the profile is active...  I *think* that 
handles update versions properly, but perhaps not unless you select the 
profile...


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2945
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71eb349de45b4d424e171d82e1ae598235b04b48
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon <ima...@apache.org>
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-HasComments: Yes

Reply via email to