Murtadha Hubail has posted comments on this change. Change subject: Enable Replication Tests on Multi-NC Setup ......................................................................
Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1364/2/asterixdb/asterix-installer/src/main/java/org/apache/asterix/installer/command/ConfigureCommand.java File asterixdb/asterix-installer/src/main/java/org/apache/asterix/installer/command/ConfigureCommand.java: Line 71: if (!Files.exists(Paths.get(localClusterPath))) { > when do we hit this case? When any of the sample files doesn't exist in an asterix distribution. https://asterix-gerrit.ics.uci.edu/#/c/1364/2/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/PersistentLocalResourceRepository.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/PersistentLocalResourceRepository.java: Line 364: > Let's use the FileReference object instead of getting the absolute Path sin Done. To contain the size of this change, I only changed this method for now. At a later stage, all files passed to the ReplicationManager should be changed to FileReferences. -- To view, visit https://asterix-gerrit.ics.uci.edu/1364 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I542b212e04469e2701690f464f821a5189b97f12 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <hubail...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <hubail...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes