abdullah alamoudi has posted comments on this change. Change subject: Add record reader and parser for CAP messages ......................................................................
Patch Set 12: (2 comments) Nothing beside what Till has already mentioned. For the object allocation, let's file an issue and fix it later (if it cause a problem to those who use it?). I did the same for the classad parser. first version created many objects, the last one reused object pools. https://asterix-gerrit.ics.uci.edu/#/c/1269/12/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/caps-adaptor-collection/caps-adaptor-collection.4.update.aql File asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/caps-adaptor-collection/caps-adaptor-collection.4.update.aql: Line 18: */ > Should we just leave this file out and renumber the following one(s)? I kno +1 https://asterix-gerrit.ics.uci.edu/#/c/1269/12/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/CAPMessageRecordReader.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/CAPMessageRecordReader.java: Line 63: // TODO: simplify the state numbers (xikui) > It would be better to use named constants instead of numbers for the state. +1 -- To view, visit https://asterix-gerrit.ics.uci.edu/1269 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia36101a0761973a9edb96b42d3dcc117661301da Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
