Xikui Wang has posted comments on this change.

Change subject: [NO ISSUE] User-defined Function Documentation update
......................................................................


Patch Set 14:

(7 comments)

Thanks for the review!

https://asterix-gerrit.ics.uci.edu/#/c/2804/14/asterixdb/asterix-doc/src/main/user-defined_function/udf.md
File asterixdb/asterix-doc/src/main/user-defined_function/udf.md:

Line 22: Apache AsterixDB supports two types of user-defined functions (UDFs): 
SQLPP function and Programming language based function.
> maybe "Apache AsterixDB supports two languages for writing user-defined fun
Done


Line 26: mainly focus on how to install/invoke/uninstall a programming language 
function library using the Ansible script that we provided.
> s/programming language function/Java/g
Done


Line 27: Currently, AsterixDB only supports Java based programming UDF and we 
are working on supporting more languages. :)
> dunno if this really belongs here
Done


Line 33: to deploy an AsterixDB instance on your local machine or cluster. The 
UDFs have to be installed offline. Here are the
> "This section assumes you have followed the preceding ansible installation 
Done


Line 44: - Step 3: Start the AsterixDB
> no 'the'
Done


Line 48: After AsterixDB starts, you can use the following query to check 
whether your UDFs are sucessfully installed.
> are/have been
Done


Line 54: the `asterixdb-external` sub-project. Assuming the UDFs are installed 
into the `udfs` dataverse and `testlib` library,
> this is sort of vague, assumes knowledge of maven
couldn't find a better way to point people to the right place.... let's if the 
others have better ideas about this...


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2804
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17b1b4d639ca38689298ce88145257e794eb90e1
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang <xkk...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <ima...@apache.org>
Gerrit-Reviewer: Ian2 Maxon <ima...@uci.edu>
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Carey <dtab...@gmail.com>
Gerrit-Reviewer: Taewoo Kim <wangs...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Wail Alkowaileet <wael....@gmail.com>
Gerrit-Reviewer: Xikui Wang <xkk...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to