Dmitry Lychagin has posted comments on this change. Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins ......................................................................
Patch Set 93: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1076/93/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java: Line 269 Why this was removed? the rule scans the whole plan starting from the root. why run rewritePre() on each operator? https://asterix-gerrit.ics.uci.edu/#/c/1076/93/asterixdb/asterix-app/src/test/resources/optimizerts/only.txt File asterixdb/asterix-app/src/test/resources/optimizerts/only.txt: Line 20: #inverted-index-join-noeqjoin/ngram-jaccard-inline.sqlpp why are these added and commented out? Is this intentional? https://asterix-gerrit.ics.uci.edu/#/c/1076/93/asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml File asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml: Line 2453: <!--test-case FilePath="fuzzyjoin"> are these disabled intentionally? if yes, then should these queries be included this change at all? -- To view, visit https://asterix-gerrit.ics.uci.edu/1076 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc Gerrit-PatchSet: 93 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li <lwhay...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Chen Li <che...@gmail.com> Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Luo Chen <cl...@uci.edu> Gerrit-Reviewer: Taewoo Kim <wangs...@gmail.com> Gerrit-Reviewer: Wenhai Li <lwhay...@gmail.com> Gerrit-HasComments: Yes
