James Fang has posted comments on this change. Change subject: [ASTERIXDB-2459][FUN] Add sttdev() aggregate function ......................................................................
Patch Set 7: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/2990/7/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/serializable/std/AbstractSerializableSingleVariableStatisticsAggregateFunction.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/serializable/std/AbstractSerializableSingleVariableStatisticsAggregateFunction.java: Line 104: moments = new SingleVarFunctionsUtil(); > let's create this object in the field definition, like we do for other fiel Done https://asterix-gerrit.ics.uci.edu/#/c/2990/7/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractSingleVarStatisticsAggregateFunction.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractSingleVarStatisticsAggregateFunction.java: Line 102: moments = new SingleVarFunctionsUtil(); > let's create this object in the field definition, like we do for other fiel Done https://asterix-gerrit.ics.uci.edu/#/c/2990/7/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/SingleVarFunctionsUtil.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/SingleVarFunctionsUtil.java: Line 19: package org.apache.asterix.runtime.utils; > let's move it to org.apache.asterix.runtime.aggregates.util package becaus Done Line 21: public class SingleVarFunctionsUtil { > Can we add some javadocs describing this class and include a reference to t Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2990 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia709669a9d20358f11ad28f453ae8ad8551f6334 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: James Fang <jfang...@ucr.edu> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: James Fang <jfang...@ucr.edu> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-HasComments: Yes
