Till Westmann has posted comments on this change. Change subject: Cleanup type exceptions and error messages in the compiler. ......................................................................
Patch Set 4: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1371/4/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java: Line 81: private static final String ERROR_MESSAGE_DUPLICATE_FIELD = "Get duplicate fields \"%1$s\""; Should we call this 'Duplicate field name "..."'? It's about the field name, right? -- To view, visit https://asterix-gerrit.ics.uci.edu/1371 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bdb21251e53ac552e85ba30b8105f534bf9f4f3 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
