Ian Maxon has posted comments on this change. Change subject: Deferred result retrieval for the QueryService ......................................................................
Patch Set 3: Code-Review+1 (1 comment) Seems fine to me besides the sonarqube comments https://asterix-gerrit.ics.uci.edu/#/c/1373/3/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/ResultExtractor.java File asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/ResultExtractor.java: Line 41: public static InputStream extract(InputStream resultStream) throws Exception { Why not pull this variable up to the class? -- To view, visit https://asterix-gerrit.ics.uci.edu/1373 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72d53be824d8dbf1d9f547b01f19097d0dc18add Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-HasComments: Yes
