Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2286][COMP] Parallel sort changes p.2 ......................................................................
Patch Set 4: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3005/4/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/SequentialMergeExchangePOperator.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/SequentialMergeExchangePOperator.java: PS4, Line 78: childPartitioning can childPartitioning be null? should we check it here? https://asterix-gerrit.ics.uci.edu/#/c/3005/4/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EnforceStructuralPropertiesRule.java File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EnforceStructuralPropertiesRule.java: Line 307: Are there any changes in these two methods, or they've just been moved as is? -- To view, visit https://asterix-gerrit.ics.uci.edu/3005 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie37e03b6fc6e55fc21f8324c0f09a7fa05b51769 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-HasComments: Yes
