Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2474][COMP] Remove physical optimization static variable ......................................................................
Patch Set 1: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3020/1/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/OptimizationConfUtil.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/OptimizationConfUtil.java: Line 90: } catch (IllegalArgumentException e) { > CRITICAL SonarQube violation: Should we also catch NumberFormatException here? Seems like StorageUtil.getSizeInBytes can throw it as well. Line 114: : OptionTypes.POSITIVE_INTEGER.parse(valueInQuery); POSITIVE_INTEGER.parse can throw IllegalArgumentException and NumberFormatException. Should we catch them here? -- To view, visit https://asterix-gerrit.ics.uci.edu/3020 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83f58715e5d643fa5b52f6e0a0d1ad1cb839f895 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
