Dmitry Lychagin has posted comments on this change. Change subject: [NO ISSUE][COMP] fix resolving PK field accesses & rewriting of meta() ......................................................................
Patch Set 2: Code-Review+2 (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3018/2/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java: Line 286: "Field assignOp " + assignOp.getExpressions().get(0).getValue() Minor. Should remain "Field access", not "Field assignOp", right? -- To view, visit https://asterix-gerrit.ics.uci.edu/3018 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d38cbfcc4a0eee51abf753a7d958dafa666aabf Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
