Murtadha Hubail has posted comments on this change. Change subject: Introduce CheckpointManager API ......................................................................
Patch Set 4: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1380/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java: Line 251: if (!pendingFailbackCompletion) { > It's not a checkpoint, but it's checkpointy ;) Done ;) https://asterix-gerrit.ics.uci.edu/#/c/1380/4/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StorageConstants.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StorageConstants.java: Line 29: private static final int LOCAL_STORAGE_VERSION = 1; > Why a separate version? ITreeIndexMetaDataFrame.VERSION is Hyracks storage version. It shouldn't be changed just because some Asterix related storage artifact format changed (e.g. checkpoint format). Ideally, even the Hyracks storage version should be passed from the App running on top of Hyracks. The VERSON attribute below combines both the Asterix version as well as the Hyracks storage version to ensure that if any of them changed then a version mismatch is encountered. https://asterix-gerrit.ics.uci.edu/#/c/1380/4/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/CheckpointThread.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/CheckpointThread.java: Line 28: /** > s/demon/daemon Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1380 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36c00ca195b93bbe1e53f39bb4a3b5a344657f0d Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <hubail...@gmail.com> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <hubail...@gmail.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
