Hussain Towaileb has posted comments on this change. Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++ ......................................................................
Patch Set 13: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/3031/12/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_missing_result/array_slice_missing_result.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_missing_result/array_slice_missing_result.3.query.sqlpp: Line 27: "t5": (array_slice([0, 1, 2, 3], 0, missing) IS MISSING), // end is missing > Do we have have testcases where MISSING is passed as a first or second argu Done. Added few more test cases for the 2 arguments version. https://asterix-gerrit.ics.uci.edu/#/c/3031/12/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_null_result/array_slice_null_result.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_null_result/array_slice_null_result.3.query.sqlpp: Line 36: "t14": (array_slice([0, 1, 2, 3], 0, "3") IS NULL), // Invalid end > Do we have have testcases where NULL is passed as a first or second argumen Done. Added few more test cases for the 2 arguments version. https://asterix-gerrit.ics.uci.edu/#/c/3031/12/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractArraySliceEval.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractArraySliceEval.java: Line 204: > We try to avoid object construction inside evaluate(). You only need at mos Done. -- To view, visit https://asterix-gerrit.ics.uci.edu/3031 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf Gerrit-PatchSet: 13 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb <hussai...@gmail.com> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Hussain Towaileb <hussai...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
