Ali Alsuliman has posted comments on this change.

Change subject: [NO ISSUE][IDX][COMP] Creating an open index on non-declared 
fields
......................................................................


Patch Set 3:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/3045/2/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/TypeUtil.java
File 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/TypeUtil.java:

PS2, Line 195: IllegalStateException
> Should this be an IllegalStateException? It seems that the message could be
Ideally, we should never hit this exception. If we did, it's an internal error, 
and that would mean the code has some bug which turned the dataset record type 
into an optional one.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3045
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f09ed73f27090c5be7b1a665f4591b29a8cda12
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Ali Alsuliman <ali.al.solai...@gmail.com>
Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com>
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: Yes

Reply via email to