Michael Blow has posted comments on this change. Change subject: [ASTERIXDB-2490][NET] Support Encrypted IPC Connections ......................................................................
Patch Set 4: (11 comments) https://asterix-gerrit.ics.uci.edu/#/c/3052/4/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/network/INetworkSecurityConfig.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/network/INetworkSecurityConfig.java: PS4, Line 44: String should this be a File? Should we name this *File instead of *Path as well? PS4, Line 58: String should this be a File? Should we name this *File instead of *Path as well? Is this a file or a directory? https://asterix-gerrit.ics.uci.edu/#/c/3052/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java: PS4, Line 78: STRING should we add a FILE type? PS4, Line 79: STRING should we add a FILE type? PS4, Line 195: A path to java key store file does this mean fully-qualified java key store file name? PS4, Line 197: A path to java trust store file does this mean fully-qualified java trust store file name? https://asterix-gerrit.ics.uci.edu/#/c/3052/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java: PS4, Line 90: STRING should we add a FILE type? PS4, Line 91: STRING should we add a FILE type? PS4, Line 216: A path to a key store file does this mean fully-qualified java key store file name? PS4, Line 218: A path to java trust store file does this mean fully-qualified trust key store file name? https://asterix-gerrit.ics.uci.edu/#/c/3052/4/hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/sockets/SslHandshake.java File hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/sockets/SslHandshake.java: PS4, Line 50: reduce possibility of overflow what happens on overflow? (there is a window) -- To view, visit https://asterix-gerrit.ics.uci.edu/3052 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7007a9be25287a94c5936d440355cfedb8e032b9 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-HasComments: Yes
