Till Westmann has posted comments on this change. Change subject: [NO ISSUE][HYR] Binary compatibility enhancements ......................................................................
Patch Set 23: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/3128/23/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java: PS23, Line 69: lookupOption(key.section().sectionName(), IOption.toIni(key.optionName()) This could be null. https://asterix-gerrit.ics.uci.edu/#/c/3128/23/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigUtils.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigUtils.java: PS23, Line 186: fixupValueForJSON change to IOption.toIni PS23, Line 197: fixupValueForJSON Is there a better place for this? https://asterix-gerrit.ics.uci.edu/#/c/3128/23/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java: PS23, Line 268: selfRegister Consider eliminating explicit registration. https://asterix-gerrit.ics.uci.edu/#/c/3128/23/hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/HyracksClientInterfaceRemoteProxy.java File hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/HyracksClientInterfaceRemoteProxy.java: PS23, Line 27: HyracksClientInterfaceFunctions Why was this needed? -- To view, visit https://asterix-gerrit.ics.uci.edu/3128 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77d4919be4853d9afe9b0137861cff3b1d751e20 Gerrit-PatchSet: 23 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
