Xikui Wang has posted comments on this change. Change subject: WIP - load from classpath ......................................................................
Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1400/2/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/ParserFactoryProvider.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/ParserFactoryProvider.java: Line 47: private static final String RESOURCE = "META-INF/services/org.apache.asterix.external.api.IDataParserFactory"; Should we make this RESOURCE as a directory? As I see from the later initFactories method, each resource file will be loaded with one class that maps to keyword. I would imagine there are multiple parser factories need to be loaded, then there may have multiple config files in this directory? -- To view, visit https://asterix-gerrit.ics.uci.edu/1400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36a3fca2df9134423fe7590be260cfc3856c7f01 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: Yes
