abdullah alamoudi has posted comments on this change. Change subject: Change the API for writing and reading metadata pages ......................................................................
Patch Set 9: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1396/9/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTree.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTree.java: Line 746: } else { > What's this about, did you find a bug unrelated to the change? hmmm, this is interesting. It is not much of a bug but before, we had an allocated slot for LSN that was by default =0 and everything worked. Now that we don't have it, someone who asks for the LSN will get an invalid because it doesn't exists and things related to replication starts to break. So I thought that since bulk load is kind of a flush, we can call the callback like we do with the regular flush operation. The callback will add the LSN and everything works. -- To view, visit https://asterix-gerrit.ics.uci.edu/1396 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iadad522ab5568677aa816c74fc1d63acad505380 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
