Till Westmann has posted comments on this change. Change subject: [NO ISSUE] Fix logging in NCServiceIT ......................................................................
Patch Set 4: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/3189/4/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/NCServiceIT.java File hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/NCServiceIT.java: PS4, Line 70: HyracksNCServiceProcess red = : I think that we can remove this again PS4, Line 72: HyracksNCServiceProcess blue = I think that we can remove this again PS4, Line 81: new File(TARGET_DIR, "cc.conf") use 'tempConf' ? PS4, Line 81: HyracksCCProcess cc = I think that we can remove this again https://asterix-gerrit.ics.uci.edu/#/c/3189/4/hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksCCProcess.java File hyracks-fullstack/hyracks/hyracks-server/src/test/java/org/apache/hyracks/test/server/process/HyracksCCProcess.java: PS4, Line 37: this.configFile = configFile; : this.logFile = logFile; : this.appHome = appHome; : this.workingDir = workingDir; this(configFile, logFile, appHome, workingDir); -- To view, visit https://asterix-gerrit.ics.uci.edu/3189 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a5944891adf6b073dee01e8418b2449e1179949 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4.1-pre-rc Gerrit-Owner: Ian Maxon <ima...@uci.edu> Gerrit-Reviewer: Ian Maxon <ima...@uci.edu> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
