Michael Blow has posted comments on this change. Change subject: ASTERIXDB-1720 - Generate License Files ......................................................................
Patch Set 8: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/1402/8/asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/LicenseMojo.java File asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/LicenseMojo.java: Line 134: final LicenseSpec l2 = urlToLicenseMap.get(o2.getLeft()); > 999? I've clarified this in the next patch. I wanted undefined licenses to have a high (e.g. 999) metric. Line 149: new URL(licenseUrl); > CRITICAL SonarQube violation: Done Line 151: } catch (MalformedURLException e) { > It probably doesn't matter in this case, but is there some way to know the Not that I could see without writing my own. https://asterix-gerrit.ics.uci.edu/#/c/1402/8/asterixdb/src/main/licenses/content/opensource.org_licenses_bsd-license.php.txt File asterixdb/src/main/licenses/content/opensource.org_licenses_bsd-license.php.txt: Line 1: <OWNER> = Regents of the University of California > Whats with this license? References to this were fixed, removing. -- To view, visit https://asterix-gerrit.ics.uci.edu/1402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0963a85cb2be47dbf6bfd8c7f6fec767ef32e7e2 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
