Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison ......................................................................
Patch Set 7: Code-Review+1 (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3173/7/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/LogicalScalarBinaryComparator.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/LogicalScalarBinaryComparator.java: Line 104: throw new IllegalStateException("Two different non-numeric tags but they are compatible"); The message should say " ... NOT compatible", right? https://asterix-gerrit.ics.uci.edu/#/c/3173/7/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/util/container/IObjectPool.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/util/container/IObjectPool.java: Line 41: boolean free(E element); minor. add javadoc. -- To view, visit https://asterix-gerrit.ics.uci.edu/3173 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
