Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2523][RT][COMP] add support for hashing record fields ......................................................................
Patch Set 2: Code-Review+2 (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3249/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/hash/AMurmurHash3BinaryHashFunctionFamily.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/hash/AMurmurHash3BinaryHashFunctionFamily.java: Line 161: int hash = 0; > I was worried about cases like hash join if for example the left branch has It seems that we should - relying on the fact that the compiler will ensure matching seeds when required. This could be a separate change. Please file an issue if you don't address this in this change. -- To view, visit https://asterix-gerrit.ics.uci.edu/3249 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d18a17089afdc6e28ff01091d890b375868969c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
