Hello Anon. E. Moose #1000171, Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/3259
to look at the new patch set (#2).
Change subject: [ASTERIXDB-2516][COMP] Change logical comparators handling of
null/missing
......................................................................
[ASTERIXDB-2516][COMP] Change logical comparators handling of null/missing
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
Change the result of comparing against null and missing.
For arrays, comparing against null or missing item will result in incomparable.
For records, comparing against a null field will result in incomparable.
- modified test cases accordingly
- moved few object factories to the common place.
- modified compareRecords to avoid string construction for field names
- few code clean-ups.
Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
---
M
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.007.adm
M
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.014.adm
M
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.021.adm
M
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.022.adm
M
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/records/records.005.adm
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/CompareHashUtil.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/AbstractAGenericBinaryComparator.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/LogicalComplexBinaryComparator.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/LogicalScalarBinaryComparator.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/hash/AMurmurHash3BinaryHashFunctionFamily.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/util/container/ObjectFactories.java
11 files changed, 67 insertions(+), 125 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/59/3259/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/3259
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman <ali.al.solai...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
