Ali Alsuliman has posted comments on this change. Change subject: [ASTERIXDB-2516][COMP] Avoid writing into buffer when comparing numbers ......................................................................
Patch Set 1: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/3272/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/AbstractAGenericBinaryComparator.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/AbstractAGenericBinaryComparator.java: PS1, Line 145: rawComp.compare(b1, s1, l1, b2, s2, l2); > Could this be replaced by comparing just the tags? Done https://asterix-gerrit.ics.uci.edu/#/c/3272/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/ComparatorUtil.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/ComparatorUtil.java: PS1, Line 95: result > Should we just return here? Done Line 104: throw new UnsupportedOperationException(); > compareNumWithConstant() and compareConstants() below return null in this c Done. Changed scalar comp accordingly. https://asterix-gerrit.ics.uci.edu/#/c/3272/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/hash/AMurmurHash3BinaryHashFunctionFamily.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/hash/AMurmurHash3BinaryHashFunctionFamily.java: PS1, Line 146: default > add Done https://asterix-gerrit.ics.uci.edu/#/c/3272/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ATypeTag.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ATypeTag.java: Line 144: public final boolean isNumber() { > we already have ATypeHierarchy.getTypeDomain() for this. Should we just use Done -- To view, visit https://asterix-gerrit.ics.uci.edu/3272 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie089d386a9ab8271f2833c05ffdfb0d484937b51 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
