Hello Anon. E. Moose #1000171, Till Westmann, Jenkins, Dmitry Lychagin, I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/3280 to look at the new patch set (#2). Change subject: [ASTERIXDB-2516][COMP] Avoid writing field names & values when comparing records ...................................................................... [ASTERIXDB-2516][COMP] Avoid writing field names & values when comparing records - user model changes: no - storage format changes: no - interface changes: no Details: ARecordVisitablePointable writes field names, field tags, and field values first before giving access to the record information. This is not ideal for comparison. A different record accessor is needed for comparison. Also, the field names should be sorted which ARecordVisitablePointable does not provide. - avoid this writing when a pointable to the name & value can be obtained (especially when the field value already includes the tag) - use UTF8Pointable cached values (string length, meta length) to compare instead of using the string comparator which would recalculate these values - refactored some common code. - removed not used methods in ARecordPointable Change-Id: I19ac95a91749b2983bf06f763e463521a97a261c --- D asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/CompareHashUtil.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/AbstractAGenericBinaryComparator.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/LogicalComplexBinaryComparator.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/hash/AMurmurHash3BinaryHashFunctionFamily.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordVisitablePointable.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/ARecordPointable.java A asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/RecordField.java A asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/SortedRecord.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ATypeTag.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/TypeTagUtil.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/util/container/ListObjectPool.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/util/container/ObjectFactories.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/utils/RecordUtil.java M hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/UTF8StringPointable.java M hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/string/UTF8StringUtil.java 15 files changed, 516 insertions(+), 459 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/80/3280/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3280 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I19ac95a91749b2983bf06f763e463521a97a261c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org>