Ian Maxon has posted comments on this change. Change subject: [NO ISSUE] Parallel Build ......................................................................
Patch Set 4: (6 comments) Something strange is going on with the implementation of JavaCharStream in the new plugin that makes it do an ArrayIndexOutOfBounds... https://asterix-gerrit.ics.uci.edu/#/c/3197/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java: Line 161: GlobalConfig.ASTERIX_LOGGER.log(Level.INFO, pe.toString(), pe); > let's just catch AlgebricksException here. That's a superclass of both Aste Done https://asterix-gerrit.ics.uci.edu/#/c/3197/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java: Line 203 > let's just catch AlgebricksException here Done https://asterix-gerrit.ics.uci.edu/#/c/3197/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ResultUtil.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ResultUtil.java: Line 128: } > remove TokenMgrException. If we catch in in the parser then it'll reach her Done https://asterix-gerrit.ics.uci.edu/#/c/3197/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java: Line 145: // we trust that "our" exceptions are serializable and have a comprehensible error message > let's remove catching TokenMgrException. If we catch it in the parser then Done https://asterix-gerrit.ics.uci.edu/#/c/3197/1/asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj File asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj: Line 291: } catch (TokenMgrException e) { > should catch TokenMgrException here instead of Error Done https://asterix-gerrit.ics.uci.edu/#/c/3197/1/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj File asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj: Line 331: } catch (TokenMgrException e) { > should catch TokenMgrException here instead of Error Done -- To view, visit https://asterix-gerrit.ics.uci.edu/3197 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f9c8bdbd4d1c56f4258efc0c7698e18a81ab15b Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-HasComments: Yes
