Ian Maxon has posted comments on this change. Change subject: [ASTERIXDB-2388] Add nodeIDs to cluster state query failure exception ......................................................................
Patch Set 2: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/3317/2/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AbstractLangTranslator.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AbstractLangTranslator.java: PS2, Line 81: cp.getNodeId() > if a node has multiple partitions, it will appear multiple times in the mes Done PS2, Line 84: REJECT_BAD_CLUSTER_STATE > right now, this exception message will appear like this: Ah, right, I misunderstood how this method worked.. Fixed PS2, Line 85: query > you might want to use something more generic than query (e.g. request) Done PS2, Line 96: if (clusterStateManager.getState().equals(ClusterState.UNUSABLE)) { : throw new AsterixException("Cluster is in " + ClusterState.UNUSABLE + " state." : + "\n One or more Node Controllers have left.\n"); : } > when is this reached? you might want to revise those checks. Yeah I didn't quite see how this was reachable either, but figured it was something I wasn't understanding. -- To view, visit https://asterix-gerrit.ics.uci.edu/3317 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I896fd0482e1db8a04dece058aa0975d3d961e731 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <ima...@uci.edu> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Ian Maxon <ima...@uci.edu> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
