Ian Maxon has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/2936 )
Change subject: [NO ISSUE][DASH] Asterixdb-dashboard: Plan Format| Flat Nested Objects on Table ...................................................................... Patch Set 13: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/2936/13//COMMIT_MSG Commit Message: https://asterix-gerrit.ics.uci.edu/#/c/2936/13//COMMIT_MSG@7 PS13, Line 7: Asterixdb-dashboard: > can probably remove now that we have [DASH] Done https://asterix-gerrit.ics.uci.edu/#/c/2936/13/asterixdb/asterix-dashboard/pom.xml File asterixdb/asterix-dashboard/pom.xml: https://asterix-gerrit.ics.uci.edu/#/c/2936/13/asterixdb/asterix-dashboard/pom.xml@161 PS13, Line 161: <templateProperties> : <asterixDashboardResourcesPrefix>asterix-dashboard/src/main/resources</asterixDashboardResourcesPrefix> : </templateProperties> > this shouldn't be here- it should default to dashboard/ for this context Done https://asterix-gerrit.ics.uci.edu/#/c/2936/13/asterixdb/asterix-dashboard/src/main/licenses/dashboard-license.ftl File asterixdb/asterix-dashboard/src/main/licenses/dashboard-license.ftl: https://asterix-gerrit.ics.uci.edu/#/c/2936/13/asterixdb/asterix-dashboard/src/main/licenses/dashboard-license.ftl@61 PS13, Line 61: dashboard > looks like the other prefixes (and this one for source license context) inc done, and im not sure I follow about the single quotes, i can't use double quotes to enclose the literal because we're already in a double quote. is there a better way to go about it? freemarker attempts to evalute the naked literal as a variable, so there must be something i am missing https://asterix-gerrit.ics.uci.edu/#/c/2936/13/asterixdb/asterix-dashboard/src/main/licenses/dashboard-license.ftl@72 PS13, Line 72: licenseFilePrefix > it looks like the other prefixes (and this one for the source license conte Done https://asterix-gerrit.ics.uci.edu/#/c/2936/13/asterixdb/src/main/licenses/templates/source_licenses.ftl File asterixdb/src/main/licenses/templates/source_licenses.ftl: https://asterix-gerrit.ics.uci.edu/#/c/2936/13/asterixdb/src/main/licenses/templates/source_licenses.ftl@141 PS13, Line 141: <#assign licenseComponent="AsterixDB Dashbaord"/> : <#assign licenseLocation="${asterixDashboardLocation!}"/> : <#assign licenseFilePrefix="${asterixDashboardResourcesPrefix!'dashboard'}"/> : === : ASTERIXDB Dashboard JS COMPONENTS: : : includes a number of packed subcomponents under : dashboard/static/ with separate copyright : notices and license terms. Your use of these subcomponents is subject : to the terms and condition of the following licenses. : === : : <@license licenseName="The Apache License, Version 2.0" component="AsterixDB Dashboard fonts" files=[ : "${licenseFilePrefix}/assets/fonts/material-icons/MaterialIcons-Regular.eot", : "${licenseFilePrefix}/assets/fonts/material-icons/MaterialIcons-Regular.svg", : "${licenseFilePrefix}/assets/fonts/material-icons/MaterialIcons-Regular.ttf", : "${licenseFilePrefix}/assets/fonts/material-icons/MaterialIcons-Regular.woff", : "${licenseFilePrefix}/assets/fonts/material-icons/MaterialIcons-Regular.woff2"]> : Embedded fonts in asterix-dashboard are from material-design-icons (https://github.com/google/material-design-icons) : : <@indent spaces=3> : <#list licenses as license> : <#if license.url == "http://www.apache.org/licenses/LICENSE-2.0.txt";> : ${license.content} : <#break> : </#if> : </#list> : </@indent> : </@license> > I think this would be an include, not copy/pasted here, for easier maintena i tried including this, however i don't believe the plugin can access outside of the <baseDir> specified? i tried both an absolute path and relative path, the former had the leading / stripped and the latter couldn't escape out of the basedir with ../ -- To view, visit https://asterix-gerrit.ics.uci.edu/2936 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a27a5576ae21b6fda440bfc281d25e62638515c Gerrit-Change-Number: 2936 Gerrit-PatchSet: 13 Gerrit-Owner: Emilio Jose Coronado Lopez <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Comment-Date: Thu, 18 Apr 2019 23:12:47 +0000 Gerrit-HasComments: Yes
