Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3338 )
Change subject: [NO ISSUE] Create an abstraction for the ForwardOperatorDescriptor ...................................................................... Patch Set 4: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/3338/4/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AbstractForwardPOperator.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AbstractForwardPOperator.java: https://asterix-gerrit.ics.uci.edu/#/c/3338/4/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AbstractForwardPOperator.java@49 PS4, Line 49: RangeMap generator could we change this now that it's generic? https://asterix-gerrit.ics.uci.edu/#/c/3338/4/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AbstractForwardPOperator.java@125 PS4, Line 125: rangemapSource could we change this to sideDataSource? (and other similar places that mention "range map") https://asterix-gerrit.ics.uci.edu/#/c/3338/4/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/SortForwardPOperator.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/SortForwardPOperator.java: https://asterix-gerrit.ics.uci.edu/#/c/3338/4/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/SortForwardPOperator.java@39 PS4, Line 39: getRangeMapKey we should probably change this now that it's not necessarily a range map. also, the ForwardOperator's "rangeMapExpression" should be renamed to a more generic one. https://asterix-gerrit.ics.uci.edu/#/c/3338/4/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/base/AbstractForwardOperatorDescriptor.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/base/AbstractForwardOperatorDescriptor.java: https://asterix-gerrit.ics.uci.edu/#/c/3338/4/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/base/AbstractForwardOperatorDescriptor.java@32 PS4, Line 32: keyInContext could we rename this to sideDataKey? https://asterix-gerrit.ics.uci.edu/#/c/3338/4/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/base/AbstractForwardOperatorDescriptor.java@46 PS4, Line 46: setActivities() could we change this to two methods: 1) createForwardDataActivity 2) createSideDataActivity Then remove the instance variables and just call these two methods inside contributeActivities. -- To view, visit https://asterix-gerrit.ics.uci.edu/3338 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc3db4b386e69a98c2a1c40dadc96eb3e1a5d4fa Gerrit-Change-Number: 3338 Gerrit-PatchSet: 4 Gerrit-Owner: James Fang <jfang...@ucr.edu> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Comment-Date: Thu, 18 Apr 2019 23:15:58 +0000 Gerrit-HasComments: Yes
