Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/2453 )
Change subject: [ASTERIXDB-2310][STO]Enforce Key Uniquness using PKIndex ...................................................................... Patch Set 24: Code-Review+2 (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2453/22/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryInsertOperatorNodePushable.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryInsertOperatorNodePushable.java: https://asterix-gerrit.ics.uci.edu/#/c/2453/22/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryInsertOperatorNodePushable.java@66 PS22, Line 66: indexForUniquessCheck > This is already a local variable. The comment is incomplete? This is a member variable. I believe you can make it a local variable inside the open method. There is no need to maintain this reference in the class. https://asterix-gerrit.ics.uci.edu/#/c/2453/22/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryInsertOperatorNodePushable.java@129 PS22, Line 129: > We only force upsert operations when the batch of a frame enters an LSM ind Got it. Missed that check. -- To view, visit https://asterix-gerrit.ics.uci.edu/2453 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a52bb75ee5b14521972999df2f45ba62adc5af1 Gerrit-Change-Number: 2453 Gerrit-PatchSet: 24 Gerrit-Owner: Luo Chen <cl...@uci.edu> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Ian Maxon <ima...@uci.edu> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Luo Chen <cl...@uci.edu> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Comment-Date: Sun, 21 Apr 2019 19:59:41 +0000 Gerrit-HasComments: Yes
