Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3351 )
Change subject: [NO ISSUE][RT] Improve PreclusteredGroupWriter ...................................................................... Patch Set 4: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3351/4/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupWriter.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupWriter.java: https://asterix-gerrit.ics.uci.edu/#/c/3351/4/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupWriter.java@172 PS4, Line 172: byte[] curTupleFieldData = curTupleAccessor.getBuffer().array(); we could move this out of the for loop, i think. no? -- To view, visit https://asterix-gerrit.ics.uci.edu/3351 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic75de2e6b64d0aacaf48096ecc9d47fc8e95c9cf Gerrit-Change-Number: 3351 Gerrit-PatchSet: 4 Gerrit-Owner: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Comment-Date: Mon, 22 Apr 2019 21:49:05 +0000 Gerrit-HasComments: Yes
