Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3355 )
Change subject: [ASTERIXDB-2554][HYR] Add UTF8 and byte array comparator factories ...................................................................... Patch Set 1: Code-Review+2 (4 comments) Feel free to forward the +2 after addressing the comments https://asterix-gerrit.ics.uci.edu/#/c/3355/1//COMMIT_MSG Commit Message: https://asterix-gerrit.ics.uci.edu/#/c/3355/1//COMMIT_MSG@16 PS1, Line 16: PointableBinaryComparatorFactory Let's add a comment to say why we still keep this factory and when to avoid using it. https://asterix-gerrit.ics.uci.edu/#/c/3355/1/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/ByteArrayPointable.java File hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/ByteArrayPointable.java: https://asterix-gerrit.ics.uci.edu/#/c/3355/1/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/ByteArrayPointable.java@92 PS1, Line 92: public static int compare move static method to the bottom https://asterix-gerrit.ics.uci.edu/#/c/3355/1/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/UTF8StringLowercasePointable.java File hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/UTF8StringLowercasePointable.java: https://asterix-gerrit.ics.uci.edu/#/c/3355/1/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/UTF8StringLowercasePointable.java@73 PS1, Line 73: public static move static method to the bottom https://asterix-gerrit.ics.uci.edu/#/c/3355/1/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/UTF8StringLowercaseTokenPointable.java File hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/UTF8StringLowercaseTokenPointable.java: https://asterix-gerrit.ics.uci.edu/#/c/3355/1/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/UTF8StringLowercaseTokenPointable.java@75 PS1, Line 75: public static int move static method to the bottom -- To view, visit https://asterix-gerrit.ics.uci.edu/3355 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied6a29210a3dc1ba9fd553fb0a67ff4340e4571f Gerrit-Change-Number: 3355 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Tue, 23 Apr 2019 23:45:07 +0000 Gerrit-HasComments: Yes
