Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3360 )
Change subject: [WIP] Introduce data generator data source functions ...................................................................... Patch Set 8: (8 comments) https://asterix-gerrit.ics.uci.edu/#/c/3360/6/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorRewriter.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorRewriter.java: https://asterix-gerrit.ics.uci.edu/#/c/3360/6/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorRewriter.java@101 PS6, Line 101: */ > The methods are not needed. SQ was just complaining as there are curly brac Done https://asterix-gerrit.ics.uci.edu/#/c/3360/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_all_tables/datagen_sf_1_all_tables.1.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_all_tables/datagen_sf_1_all_tables.1.ddl.sqlpp: https://asterix-gerrit.ics.uci.edu/#/c/3360/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_all_tables/datagen_sf_1_all_tables.1.ddl.sqlpp@1 PS7, Line 1: : : : : : : : : : : : : : : : : : > I don't think that we need this empty (except for comments) file ... Done https://asterix-gerrit.ics.uci.edu/#/c/3360/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_all_tables/datagen_sf_1_all_tables.2.update.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_all_tables/datagen_sf_1_all_tables.2.update.sqlpp: https://asterix-gerrit.ics.uci.edu/#/c/3360/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_all_tables/datagen_sf_1_all_tables.2.update.sqlpp@1 PS7, Line 1: : : : : : : : : : : : : : : : : : > same as before Done https://asterix-gerrit.ics.uci.edu/#/c/3360/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_invalid_table/datagen_sf_1_invalid_table.1.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_invalid_table/datagen_sf_1_invalid_table.1.ddl.sqlpp: https://asterix-gerrit.ics.uci.edu/#/c/3360/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_invalid_table/datagen_sf_1_invalid_table.1.ddl.sqlpp@1 PS7, Line 1: : : : : : : : : : : : : : : : : : > same as before Done https://asterix-gerrit.ics.uci.edu/#/c/3360/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_invalid_table/datagen_sf_1_invalid_table.2.update.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_invalid_table/datagen_sf_1_invalid_table.2.update.sqlpp: https://asterix-gerrit.ics.uci.edu/#/c/3360/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_invalid_table/datagen_sf_1_invalid_table.2.update.sqlpp@1 PS7, Line 1: : : : : : : : : : : : : : : : : : > same as before Done https://asterix-gerrit.ics.uci.edu/#/c/3360/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_invalid_table/datagen_sf_1_invalid_table.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_invalid_table/datagen_sf_1_invalid_table.3.query.sqlpp: https://asterix-gerrit.ics.uci.edu/#/c/3360/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_invalid_table/datagen_sf_1_invalid_table.3.query.sqlpp@23 PS7, Line 23: invalid_tabl > What is call_center1? Done. call_center1 is to trigger the invalid table name exception, I probably should've used "invalid_table_name" instead of "call_center1" :) https://asterix-gerrit.ics.uci.edu/#/c/3360/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_small_tables/datagen_sf_1_small_tables.1.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_small_tables/datagen_sf_1_small_tables.1.ddl.sqlpp: https://asterix-gerrit.ics.uci.edu/#/c/3360/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_small_tables/datagen_sf_1_small_tables.1.ddl.sqlpp@1 PS7, Line 1: : : : : : : : : : : : : : : : : : > same as before Done https://asterix-gerrit.ics.uci.edu/#/c/3360/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_small_tables/datagen_sf_1_small_tables.2.update.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_small_tables/datagen_sf_1_small_tables.2.update.sqlpp: https://asterix-gerrit.ics.uci.edu/#/c/3360/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/datagen_sf_1_small_tables/datagen_sf_1_small_tables.2.update.sqlpp@1 PS7, Line 1: : : : : : : : : : : : : : : : : : > same as before Done -- To view, visit https://asterix-gerrit.ics.uci.edu/3360 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb6bd6f697628395c70008e6f730bc5ca403da5e Gerrit-Change-Number: 3360 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb <hussai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb <hussai...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Comment-Date: Mon, 29 Apr 2019 04:20:48 +0000 Gerrit-HasComments: Yes
