Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3372 )
Change subject: [ASTERIXDB-2552][RT] Reuse objects on reseting buffer manager ...................................................................... Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3372/2/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/FrameFreeSlotBiggestFirst.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/FrameFreeSlotBiggestFirst.java: https://asterix-gerrit.ics.uci.edu/#/c/3372/2/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/FrameFreeSlotBiggestFirst.java@104 PS2, Line 104: // TODO(ali): fix to not release resources > In this change? If you insist. But I would prefer to do it in a later change to keep this one small and manageable. -- To view, visit https://asterix-gerrit.ics.uci.edu/3372 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88bea27e5024c621412ef609475e2a7ba1913afa Gerrit-Change-Number: 3372 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Fri, 03 May 2019 17:57:10 +0000 Gerrit-HasComments: Yes
