Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3374 )
Change subject: [NO ISSUE][COMP] Make memory requirements an operator property ...................................................................... Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3374/2/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java: https://asterix-gerrit.ics.uci.edu/#/c/3374/2/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java@135 PS2, Line 135: inputFileSize should we remove this too? it seems that the inputFileSize depends on the frame limit which we can calculate later at code gen when we get the frame limit from the local memory requirements object. no? https://asterix-gerrit.ics.uci.edu/#/c/3374/2/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/HybridToInMemoryHashJoinRule.java File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/HybridToInMemoryHashJoinRule.java: https://asterix-gerrit.ics.uci.edu/#/c/3374/2/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/HybridToInMemoryHashJoinRule.java@37 PS2, Line 37: rewritePre I think with "Pre" we will not descend to inputs if the currently visited operator returns true (i.e. changed from hybrid to in memory). no? -- To view, visit https://asterix-gerrit.ics.uci.edu/3374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3481ddfe163c6ce786290c540cbd05db16a7f64f Gerrit-Change-Number: 3374 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Tue, 07 May 2019 03:23:58 +0000 Gerrit-HasComments: Yes
