Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/2936 )
Change subject: [NO ISSUE][DASH] Plan Format, Flat Nested Objects on Table ...................................................................... Patch Set 15: (8 comments) https://asterix-gerrit.ics.uci.edu/#/c/2936/15/asterixdb/LICENSE File asterixdb/LICENSE: https://asterix-gerrit.ics.uci.edu/#/c/2936/15/asterixdb/LICENSE@324 PS15, Line 324: asterix-dashboard/src/main/resources/asterix-dashboard/src/main/resources/assets/fonts/material-icons/MaterialIcons-Regular.eot, : asterix-dashboard/src/main/resources/asterix-dashboard/src/main/resources/assets/fonts/material-icons/MaterialIcons-Regular.svg, : asterix-dashboard/src/main/resources/asterix-dashboard/src/main/resources/assets/fonts/material-icons/MaterialIcons-Regular.ttf, : asterix-dashboard/src/main/resources/asterix-dashboard/src/main/resources/assets/fonts/material-icons/MaterialIcons-Regular.woff, : and : asterix-dashboard/src/main/resources/asterix-dashboard/src/main/resources/assets/fonts/material-icons/MaterialIcons-Regular.woff2 see comment in template (duplicate asterix-dashboard/src/main/resources/) https://asterix-gerrit.ics.uci.edu/#/c/2936/15/asterixdb/asterix-dashboard/src/main/licenses/dashboard-license.ftl File asterixdb/asterix-dashboard/src/main/licenses/dashboard-license.ftl: https://asterix-gerrit.ics.uci.edu/#/c/2936/15/asterixdb/asterix-dashboard/src/main/licenses/dashboard-license.ftl@59 PS15, Line 59: <#assign licenseComponent="AsterixDB Dashboard"/> this is not used, it's overridden in macro use below https://asterix-gerrit.ics.uci.edu/#/c/2936/15/asterixdb/asterix-dashboard/src/main/licenses/dashboard-license.ftl@60 PS15, Line 60: <#assign licenseLocation="${asterixAppLocation!}"/> : <#assign licenseFilePrefix="${asterixDashboardResourcesPrefix!'dashboard/'}"/> it would be cleaner I think to define these as parameters to the license macro, see comments in main license template https://asterix-gerrit.ics.uci.edu/#/c/2936/15/asterixdb/asterix-dashboard/src/main/licenses/dashboard-license.ftl@63 PS15, Line 63: ASTERIXDB Dashboard JS COMPONENTS is this correct? (I wonder if we should capitalize all or none, because I believe we normally refer to *DB as 'AsterixDB' or 'Apache AsterixDB' https://asterix-gerrit.ics.uci.edu/#/c/2936/15/asterixdb/asterix-dashboard/src/main/licenses/dashboard-license.ftl@65 PS15, Line 65: under : dashboard/static/ remove https://asterix-gerrit.ics.uci.edu/#/c/2936/15/asterixdb/src/main/licenses/templates/source_licenses.ftl File asterixdb/src/main/licenses/templates/source_licenses.ftl: https://asterix-gerrit.ics.uci.edu/#/c/2936/15/asterixdb/src/main/licenses/templates/source_licenses.ftl@142 PS15, Line 142: Dashbaord sp https://asterix-gerrit.ics.uci.edu/#/c/2936/15/asterixdb/src/main/licenses/templates/source_licenses.ftl@143 PS15, Line 143: <#assign licenseLocation="${asterixDashboardLocation!}"/> : <#assign licenseFilePrefix="${asterixDashboardResourcesPrefix!'dashboard/'}"/> it would be cleaner I think to define these as parameters to the license macro, as is done in the hive license above https://asterix-gerrit.ics.uci.edu/#/c/2936/15/asterixdb/src/main/licenses/templates/source_licenses.ftl@149 PS15, Line 149: ${licenseFilePrefix} this results in a duplicate prefix, as the license macro already prepends 'licenseFilePrefix' -- To view, visit https://asterix-gerrit.ics.uci.edu/2936 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a27a5576ae21b6fda440bfc281d25e62638515c Gerrit-Change-Number: 2936 Gerrit-PatchSet: 15 Gerrit-Owner: Emilio Jose Coronado Lopez <emilio.mob...@gmail.com> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Ian Maxon <ima...@uci.edu> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Comment-Date: Fri, 10 May 2019 17:56:26 +0000 Gerrit-HasComments: Yes
