Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3394 )
Change subject: [NO ISSUE][*DB][CLUS] Add support for a rebalance required cluster state ...................................................................... Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3394/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java: https://asterix-gerrit.ics.uci.edu/#/c/3394/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java@195 PS1, Line 195: if (state != ClusterState.ACTIVE && state != ClusterState.RECOVERING) { : setState(ClusterState.PENDING); : } > is this needed? looks like some unnecessary transient state that will be ch This ensures that we always transition from UNUSABLE -> PENDING -> RECOVERING -> [REBALANCE_REQUIRED ->] ACTIVE in case of normal startup- this might be helpful for cluster event subscribers. -- To view, visit https://asterix-gerrit.ics.uci.edu/3394 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I863f8bf3fe1ce8d59522c9a28a1283006ffa414c Gerrit-Change-Number: 3394 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Comment-Date: Wed, 15 May 2019 11:43:54 +0000 Gerrit-HasComments: Yes
