Till Westmann has posted comments on this change. Change subject: AsterixDB & Hyracks Source Assemblies, Licensing ......................................................................
Patch Set 3: (3 comments) Looks good, however there is an issue with EPL for sources. I think that we have determined before that the version of RainbowVis that we bundle was released before the re-licensing from MIT to EPL, so unless our version has changed since the last release that should still be the case. https://asterix-gerrit.ics.uci.edu/#/c/1439/3/asterixdb/LICENSE File asterixdb/LICENSE: Line 485: asterix-examples/src/main/resources/tweetbook-demo/static/js/rainbowvis.js This changed to EPL here: https://github.com/anomal/RainbowVis-JS/commit/458068f75134f9ae26c77c19e977de650a2595e0 I think that our version is older than this. Otherwise we'll have to pull this out as EPL cannot be part of a source distribution https://www.apache.org/legal/resolved#category-b . https://asterix-gerrit.ics.uci.edu/#/c/1439/3/asterixdb/src/main/licenses/templates/source_only_licenses.ftl File asterixdb/src/main/licenses/templates/source_only_licenses.ftl: Line 81: Eclipse Public License - v 1.0 Same EPL comments apply here. https://asterix-gerrit.ics.uci.edu/#/c/1439/3/hyracks-fullstack/hyracks-fullstack-license/src/main/licenses/templates/source_licenses.ftl File hyracks-fullstack/hyracks-fullstack-license/src/main/licenses/templates/source_licenses.ftl: Line 44: ${isare} available under ${licenseName}: Should it always be "are" if the paragraph starts with "Portions"? -- To view, visit https://asterix-gerrit.ics.uci.edu/1439 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bd8694ad85f25f9b61182ec18fdc39f74480685 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
