Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3425 )
Change subject: [NO ISSUE][OTH] Add API To Get Dataset Size ...................................................................... Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3425/1/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/PersistentLocalResourceRepository.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/PersistentLocalResourceRepository.java: https://asterix-gerrit.ics.uci.edu/#/c/3425/1/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/PersistentLocalResourceRepository.java@618 PS1, Line 618: return resourceReference.getDataverse().equals(datasetIdentifier.getDataverse()) : && resourceReference.getDataset().equals(datasetIdentifier.getDataset()) : && resourceReference.getRebalance().equals(datasetIdentifier.getRebalance()); > should we locate this logic inside of the DatasetCopyIdentifier, to avoid i Done -- To view, visit https://asterix-gerrit.ics.uci.edu/3425 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaff87bbe1f2417689f7827deaf03fcddd64ca7e4 Gerrit-Change-Number: 3425 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Comment-Date: Fri, 07 Jun 2019 16:48:21 +0000 Gerrit-HasComments: Yes
