>From Ali Alsuliman <[email protected]>: Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4023 )
Change subject: [ASTERIXDB-2667][FUN] Share code base between string functions ...................................................................... Patch Set 17: (3 comments) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4023/17/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractConcatStringEval.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractConcatStringEval.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4023/17/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractConcatStringEval.java@149 PS17, Line 149: typeTag == ATypeTag.NULL minor, I think typeTag is never NULL when we reach to this code https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4023/17/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractConcatStringEval.java@289 PS17, Line 289: UTF8StringUtil.getUTFLength(separatorBytes, separatorStartOffset + 1) We can move this out of the for-loop. That is calculate it only once and then use it here. Same thing in the the below method. (it used to be like this, i think) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4023/17/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractConcatStringEval.java@304 PS17, Line 304: tempLengthArray we should reset tempLengthArray and fill it with 0s before -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4023 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I41b644c6841b222d1c6c529b2f9189f42178e28c Gerrit-Change-Number: 4023 Gerrit-PatchSet: 17 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-CC: Anon. E. Moose #1000209 Gerrit-Comment-Date: Mon, 09 Dec 2019 06:49:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
