abdullah alamoudi has posted comments on this change. Change subject: Introduce IStorageComponentProvider ......................................................................
Patch Set 1: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1451/1/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java: Line 260: compactionInfo.first, compactionInfo.second); > How do you capture isPartitioned in the new code? inside the call :) but I am sure you know that already by this time... https://asterix-gerrit.ics.uci.edu/#/c/1451/1/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/ValidateUtil.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/ValidateUtil.java: Line 31: import org.apache.hyracks.algebricks.common.exceptions.AlgebricksException; > I think the exception used here should be CompilationException, with error mostly using compilation exception in the implementation. though, fixing all of them is a lot of "boring" work. I however, fixed a bunch. https://asterix-gerrit.ics.uci.edu/#/c/1451/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/file/StorageManager.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/file/StorageManager.java: Line 25: public class StorageManager implements IStorageManager { > The storage manager is instantiated at a number of places in the code base, I agree. but metadata initialization :(( we can still do something about it... later? -- To view, visit https://asterix-gerrit.ics.uci.edu/1451 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If86750cdb2436c713f6598e54d4aaaf23d9f7bbf Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
