>From Hussain Towaileb <[email protected]>: Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10783 )
Change subject: [NO ISSUE][EXT] Avoid duplicate open for streams + minor refactoring ...................................................................... Patch Set 1: (3 comments) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10783/1/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/abstracts/AbstractExternalInputStreamFactory.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/abstracts/AbstractExternalInputStreamFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10783/1/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/abstracts/AbstractExternalInputStreamFactory.java@80 PS1, Line 80: this.configuration = configuration; : this.partitionConstraint = : ((ICcApplicationContext) ctx.getApplicationContext()).getClusterStateManager().getClusterLocations(); Common, reference to configuration and setting partition constraints https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10783/1/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/aws/AwsS3InputStream.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/aws/AwsS3InputStream.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10783/1/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/aws/AwsS3InputStream.java@74 PS1, Line 74: in Use the already obtained stream https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10783/1/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10783/1/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java@a310 PS1, Line 310: public static final String CONTAINER_NAME_FIELD_NAME = "container"; : public static final String DEFINITION_FIELD_NAME = "definition"; Definition and container are common to all external datasets -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10783 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: cheshire-cat Gerrit-Change-Id: I405e84a30ee67b176c3389db6fd026c408ae1685 Gerrit-Change-Number: 10783 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Anon. E. Moose #1000171 Gerrit-Comment-Date: Tue, 30 Mar 2021 22:10:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
